Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(langchain): add throw err for JsonOutputFunctionsParser.parse #7204

Merged

Conversation

Makoq
Copy link
Contributor

@Makoq Makoq commented Nov 14, 2024

When use the method of JsonOutputFunctionsParser.parse(text: string) with input text in non-strict mode JSON string, throw description of error information to notice the developers.

It's relatively common in developing and debugging that input content is non-strict mode JSON.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 17, 2024 5:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 17, 2024 5:55am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Nov 14, 2024
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Nov 17, 2024
@jacoblee93 jacoblee93 merged commit d420b71 into langchain-ai:main Nov 17, 2024
30 checks passed
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants